Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math incorrect error on logical operations #6096

Closed
mqudsi opened this issue Sep 10, 2019 · 0 comments
Closed

math incorrect error on logical operations #6096

mqudsi opened this issue Sep 10, 2019 · 0 comments

Comments

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Sep 10, 2019

We've previously decided that the new math will not support boolean/logical operations (#4777), but it currently emits an error that isn't very helpful or strictly accurate:

mqudsi@Blitzkrieg /m/c/U/Mahmoud> math "42 > 1337"
math: Error: Missing operator
'42 > 1337'
    ^

especially because that helpful caret is, in fact, pointing pointing to an operator.. just not one that is supported.

We should probably catch some common boolean/logical operations and print a more helpful message telling the user to use test instead.

@zanchey zanchey added this to the fish-future milestone Sep 10, 2019
@faho faho removed this from the fish-future milestone Nov 1, 2019
@faho faho added this to the fish 3.1.0 milestone Nov 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants