Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web interface does not accept functions for abbreviations. #6120

Closed
caillou opened this issue Sep 16, 2019 · 5 comments
Closed

Web interface does not accept functions for abbreviations. #6120

caillou opened this issue Sep 16, 2019 · 5 comments
Labels
bug
Milestone

Comments

@caillou
Copy link

@caillou caillou commented Sep 16, 2019

If I try to create the following abbreviation through the web interface, the (git_branch_name) part is stripped away:

abbr -a ggl 'git pull origin (git_branch_name)'

Steps to reproduce

  1. Open a new terminal and run fish_config.
  2. Create the following abbreviation: 'git pull origin (git_branch_name)'.
  3. Reload the page.
  4. The abbreviation looks as follows: 'git pull origin' .
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Sep 21, 2019

Weird, I can't reproduce! What is your test environment?

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 23, 2019

Yes, this works for me on 22811eb with Chrome 76 on macOS 10.13.6.

@faho
Copy link
Member

@faho faho commented Oct 2, 2019

Okay, I can reproduce with 3.0.2, the trick is to include the single-quotes - which seems like the correct thing to do, because that's how the others are presented on the web interface.

@faho
Copy link
Member

@faho faho commented Oct 2, 2019

Can reproduce with master. This is because fish_config runs abbr --add 'ggl' ''git pull origin (git_branch_name)'' because it doesn't escape the input.

(note: You need to reload the tab to see the real result)

@faho faho added this to the fish 3.1.0 milestone Oct 2, 2019
@faho faho added bug and removed needs more info labels Oct 2, 2019
@faho
Copy link
Member

@faho faho commented Oct 2, 2019

Okay I just pushed 70fc261, which ends up ignoring all ' surrounding the input.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

No branches or pull requests

4 participants