Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change cursor type/shape in different modes - vi #6478

Closed
laxisforte opened this issue Jan 6, 2020 · 3 comments
Closed

Unable to change cursor type/shape in different modes - vi #6478

laxisforte opened this issue Jan 6, 2020 · 3 comments

Comments

@laxisforte
Copy link

fish --version
Fish version 3.02

echo $TERM
Xterm-256color

uname -a
Linux xxxxxx 4.4.0-18362-Microsoft #476-Microsoft Fri Nov 01 16:53:00 PST 2019 x86_64 x86_64 x86_64 GNU/Linux

sh -c 'env HOME=$(mktemp -d) fish'
The problem persists

  • Windows 10 version 1909
  • Windows new terminal version 0.7.345.10

fish_user_key_bindings.fish

function fish_user_key_bindings
  fish_vi_key_bindings
  fzf_key_bindings
  set -g fish_cursor_insert line
  set -g fish_cursor_replace_one underscore
  set -g fish_cursor_visual block
  bind -M insert -m default jj backward-char force-repaint
  bind -M insert hh forward-word force-repaint
  bind -M insert \r 'replace_then_execute'
end

config.fish

set -U fish_greeting ""
set theme_color_scheme dracula
set -g FZF_CTRL_T_COMMAND "fd --type f --hidden --follow --exclude .git"

Cursor shape (solid box) is same in all modes...
Any suggestion ?
Thank you,
P.

@faho
Copy link
Member

faho commented Jan 6, 2020

We only change the cursor if we think the terminal can do it. I've not looked at the new windows terminal. Can it change the cursor? How can we detect it? (Note that I'm pretty sure that like 95% of all terminals it sets $TERM to xterm-256color, so that's out)

@faho faho added this to the fish-future milestone Jan 6, 2020
@faho
Copy link
Member

faho commented Jan 19, 2020

@laxisforte Can you tell us what set -q WT_SESSION && echo YES $WT_SESSION prints in the new terminal and ideally the old one?

@faho
Copy link
Member

faho commented May 16, 2020

Fixed by 76bbcb9

@faho faho closed this as completed May 16, 2020
@faho faho modified the milestones: fish-future, fish 3.2.0 May 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants