When changed to 8-bit encoding, fish attempts to use ellipsis. #649

Closed
xfix opened this Issue Apr 8, 2013 · 3 comments

Comments

Projects
None yet
4 participants
@xfix
Member

xfix commented Apr 8, 2013

glitchmr@pineapple ~> echo $LANG
pl_PL.UTF-8
glitchmr@pineapple ~> echo ~/.config/fish/
…fig/fish/completions/ …fig/fish/fish_history …fig/fish/fish_read_history …fig/fish/fishd.pineapple …fig/fish/functions/ …fig/fish/generated_completions/
glitchmr@pineapple ~> set LANG pl_PL.ISO-8859-2
glitchmr@pineapple ~> echo ~/.config/fish/
…fig/fish/comp$ …fig/fish/fish$ …fig/fish/fish_read$ …fig/fish/fishd.p$ …fig/fish/fu$ …fig/fish/generated_comp$
glitchmr@pineapple ~>

Paths begin with … that ISO-8859-2 doesn't have, and end with $ cutting last seven characters of name.

@ridiculousfish

This comment has been minimized.

Show comment Hide comment
@ridiculousfish

ridiculousfish Apr 18, 2013

Owner

I think what's going on is something like this:

  1. Modifying $LANG calls setlocale
  2. setlocale fails. The locale remains pl_PL.UTF-8, which is Unicode, and therefore the ellipsis character is still three dots.
  3. When you tab complete, fish_pager is started. It sees $LANG = pl_PL.ISO-8859-2. The locale is initialized to "C", which is not Unicode

So the crazy …fig/fish/comp$ …fig/fish/fish$ is explained like so: the $ is from fish_pager, which inherited a busted locale. The ellipsis is from fish, which inherited an OK locale, and refused to change it.

Owner

ridiculousfish commented Apr 18, 2013

I think what's going on is something like this:

  1. Modifying $LANG calls setlocale
  2. setlocale fails. The locale remains pl_PL.UTF-8, which is Unicode, and therefore the ellipsis character is still three dots.
  3. When you tab complete, fish_pager is started. It sees $LANG = pl_PL.ISO-8859-2. The locale is initialized to "C", which is not Unicode

So the crazy …fig/fish/comp$ …fig/fish/fish$ is explained like so: the $ is from fish_pager, which inherited a busted locale. The ellipsis is from fish, which inherited an OK locale, and refused to change it.

@zanchey

This comment has been minimized.

Show comment Hide comment
@zanchey

zanchey Oct 6, 2014

Member

With the death of fish_pager, does this still happen?

Member

zanchey commented Oct 6, 2014

With the death of fish_pager, does this still happen?

@faho

This comment has been minimized.

Show comment Hide comment
@faho

faho Feb 8, 2016

Member

I can't reproduce anymore and there's been a lot of changes. If anyone still gets this we'll reopen.

Member

faho commented Feb 8, 2016

I can't reproduce anymore and there's been a lot of changes. If anyone still gets this we'll reopen.

@faho faho closed this Feb 8, 2016

@faho faho removed this from the fish-future milestone Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment