Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in checks/bad-option.fish on OpenIndiana #6554

Closed
Mno-hime opened this issue Jan 30, 2020 · 2 comments
Closed

Failure in checks/bad-option.fish on OpenIndiana #6554

Mno-hime opened this issue Jan 30, 2020 · 2 comments
Labels
bug Something that's not working as intended
Milestone

Comments

@Mno-hime
Copy link

fish 3.1 beta1 test suite compiled with GCC 6.5 fails on OpenIndiana with:

Testing file checks/bad-option.fish ... Failure in checks/bad-option.fish:

  The CHECKERR on line 2 wants:
    {{.*fish}}: {{unrecognized option: Z|invalid option -- '?Z'?|unknown option -- Z}}

  which failed to match line stderr:1:
    ../test/root/bin/fish: illegal option -- Z

  when running command:
    ../test/root/bin/fish -Z
@zanchey
Copy link
Member

zanchey commented Jan 30, 2020

This is a platform-specific message from getopt_long, so I guess that's why it fails.

@zanchey zanchey added the bug Something that's not working as intended label Jan 30, 2020
@faho
Copy link
Member

faho commented Jan 30, 2020

Luckily littlecheck allows for multiple messages here. So the option can be "unrecognized", "invalid", "unknown", "illegal", "bogus", "bad", "green" or "mysterious".

@faho faho closed this as completed in e8000cf Jan 30, 2020
faho added a commit that referenced this issue Jan 30, 2020
Just another version of the error. We still want to get a bug if it
ever triggers a *wrong* error, so we still list all the options
instead of going for `.*option:.*Z.*`.

Fixes #6554

(cherry picked from commit e8000cf)
@krobelus krobelus modified the milestones: fish-future, fish 3.1.0 Jan 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

4 participants