Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure in checks/wildcard.fish on OpenIndiana #6558

Closed
Mno-hime opened this issue Jan 30, 2020 · 0 comments
Closed

Failure in checks/wildcard.fish on OpenIndiana #6558

Mno-hime opened this issue Jan 30, 2020 · 0 comments
Labels
bug
Milestone
fish 3.1.0

Comments

@Mno-hime
Copy link

@Mno-hime Mno-hime commented Jan 30, 2020

fish 3.1 beta1 test suite compiled with GCC 6.5 fails on OpenIndiana with:

Testing file checks/wildcard.fish ... Failure in checks/wildcard.fish:

  There were no remaining checks left to match stderr:1:
    rm: Cannot remove any directory in the path of the current working directory

  when running command:
    ../test/root/bin/fish checks/wildcard.fish
@Mno-hime Mno-hime mentioned this issue Jan 30, 2020
Closed
@zanchey zanchey added the bug label Jan 30, 2020
@zanchey zanchey added this to the fish-future milestone Jan 30, 2020
faho added a commit that referenced this issue Jan 30, 2020
@faho
Tests: Don't remove a parent of $PWD
105a256 
Solaris/OpenIndiana/Illumos `rm` checks that and errors out.

In these cases we don't actually need it to be a part of $PWD as
it's just for cleanup, so we `cd` out before.

See #5472
See 1ee57e9
Fixes #6555
Fixes #6558

(cherry picked from commit 9cbd3d5)
@krobelus krobelus removed this from the fish-future milestone Jan 30, 2020
@krobelus krobelus added this to the fish 3.1.0 milestone Jan 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
fish 3.1.0
Development

No branches or pull requests
3 participants
@zanchey @Mno-hime @krobelus