Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection syntax seems broken #6591

Closed
jschank opened this issue Feb 13, 2020 · 2 comments
Closed

Redirection syntax seems broken #6591

jschank opened this issue Feb 13, 2020 · 2 comments
Labels
bug regression
Milestone

Comments

@jschank
Copy link

@jschank jschank commented Feb 13, 2020

#4194

fish version:
fish, version 3.1.0

OS:
Darwin serenity 19.3.0 Darwin Kernel Version 19.3.0: Thu Jan 9 20:58:23 PST 2020; root:xnu-6153.81.5~1/RELEASE_X86_64 x86_64

Did not try fish without third-party customizations.

I have a script (.fish) which attempts to execute this line:
git checkout master > /dev/null ^&1

Issue #4194, which is closed, indicates that I am using the correct syntax.

However I get this error

~/.config/fish/functions/git-clean-branches.fish (line 51): Expected a string, but instead found a '&'
git checkout master > /dev/null ^&1

This script was unchanged, and started breaking today.

Thanks,
John Schank

@zanchey
Copy link
Member

@zanchey zanchey commented Feb 13, 2020

Yes, I think that's broken.

As a workaround (and as recommended in future, as the ^ syntax will eventually be removed), you can use >/dev/null 2>&1.

@zanchey zanchey added bug regression labels Feb 13, 2020
@zanchey zanchey added this to the fish-future milestone Feb 13, 2020
@faho faho removed this from the fish-future milestone Feb 13, 2020
@faho faho added this to the fish 3.1.1 milestone Feb 13, 2020
@faho
Copy link
Member

@faho faho commented Feb 14, 2020

Bisects to 35671dd.

@faho faho closed this as completed in 13b470a Feb 14, 2020
zanchey pushed a commit that referenced this issue Feb 22, 2020
This was lost in 35671dd.

Even tho we plan to drop caret redirection, while it's there it should
fully work.

Fixes #6591.

(cherry picked from commit 13b470a)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug regression
Projects
None yet
Development

No branches or pull requests

4 participants
@jschank @zanchey @faho and others