How about taking autocomplete data from history command? #66

Closed
suhastech opened this Issue Jun 7, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@suhastech

Hi,

I'm big fan of autocomplete, have been using Ctrl + R quite frequently. I recently switched to fish. Even have it my .bashrc file.
It doesn't have the data from my previous shell. So, doesn't autocomplete yet. I think you guys can take the data from the history command?

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jun 8, 2012

Member

I think this is a request to initially populate history from bash.

Member

ridiculousfish commented Jun 8, 2012

I think this is a request to initially populate history from bash.

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Jun 8, 2012

Member

It's a good idea to import history from bash (and may be others shells too). But not all bash commands are valid fish commands. For e.g. 'export foo' is not valid in fish. We want to be as accurate as possible with our autosuggestions, and it's a different struggle to trasform (or may be ignore) invalid fish commands.

PS I have already done some work to import aliases, bash prompt and environment variables from bash. It's in import_config branch of our repository.

Member

siteshwar commented Jun 8, 2012

It's a good idea to import history from bash (and may be others shells too). But not all bash commands are valid fish commands. For e.g. 'export foo' is not valid in fish. We want to be as accurate as possible with our autosuggestions, and it's a different struggle to trasform (or may be ignore) invalid fish commands.

PS I have already done some work to import aliases, bash prompt and environment variables from bash. It's in import_config branch of our repository.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jun 12, 2012

Member

Let's aim for a history importer that handles bash and fish 1.x

Member

ridiculousfish commented Jun 12, 2012

Let's aim for a history importer that handles bash and fish 1.x

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 10, 2012

Member

fish now imports (most of) bash's history, if it cannot find its own history.

To git@github.com:fish-shell/fish-shell.git
69ace20..6f0b00f master -> master

Member

ridiculousfish commented Jul 10, 2012

fish now imports (most of) bash's history, if it cannot find its own history.

To git@github.com:fish-shell/fish-shell.git
69ace20..6f0b00f master -> master

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Jul 10, 2012

Member

Instead of maintaining a list of commands which can not be imported from bash, may be we can just check whether a command is valid in fish. For e.g for builtins we can use builtin_exists() method

Member

siteshwar commented Jul 10, 2012

Instead of maintaining a list of commands which can not be imported from bash, may be we can just check whether a command is valid in fish. For e.g for builtins we can use builtin_exists() method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment