Cursor shape does not update correctly in vi mode

[wylfen]

I recently updated to the most current release of fish, version 3.1.0. I found that in the new version, the cursor shape is not updated correctly anymore when using vi mode. I confirmed this for current master as well.

$ rg cursor ~/.config/fish/fish_variables
30:SETUVAR fish_cursor_default:block\x1eblink
31:SETUVAR fish_cursor_insert:line\x1eblink
32:SETUVAR fish_cursor_replace_one:underscore\x1eblink
33:SETUVAR fish_cursor_visual:block

With the above settings, in a new session, fish shows the correct line shape. It switches to block shape when I press ESC. However, it does not switch back to line if I then enter insert mode with a or i. It also does not switch to underscore if I press r.

I bisected this issue and traced it back to ff5524944, which removed event handler support for implicit sets. Such a set is present in input.cpp:

fish-shell/src/input.cpp

Line 192 in e1a08e3

vars.set_one(FISH_BIND_MODE_VAR, ENV_GLOBAL, bm);

To confirm this, I added code to input.cpp that would collect fired events in an event_t vector, and passed it to event_fire. With that change, the cursor updated correctly again.

I planned to send a pull request along with this report, but for this I am not familiar enough with the codebase (this is my first glance at it).

[ridiculousfish]

Wow, amazing digging. Thank you! I'll take a look.

[ridiculousfish]

Should be fixed in master as 5886b96 and 3.1.1 as acad9b0. Thank you for filing, this was awesome.

[niilz]

It sounds like this got fixed in 3.1.1. But I have just updated to 3.1.2 (via installer on MacOS Catalina 10.15). And when I try set -g fish_cursor_insert line, either from command-line or in config.fish, the cursor is still displayed as block when in insert mode.
I use fish within alacritty.
Also I wonder whether it is normal that inside fish_variables it says # VERSION: 3.0

[faho]

@niilz That's 3c6c8d5. Fish doesn't have alacritty in its whitelist.

That change happened after 3.1.2, so it's going to be in the next release. If you want you can download that file yourself and put it in ~/.config/fish/functions.

[niilz]

Thanks for the immediate response. This works perfectly.