Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time format is locale dependent #6757

Closed
faho opened this issue Mar 15, 2020 · 0 comments
Closed

time format is locale dependent #6757

faho opened this issue Mar 15, 2020 · 0 comments
Labels
bug Something that's not working as intended
Milestone

Comments

@faho
Copy link
Member

faho commented Mar 15, 2020

Yet another case of "numbers are awful":

The time output format uses the locale's decimal separator, which makes the test fail if run with e.g. LANG=de_DE.UTF-8.

This wasn't caused by f864bd8, but that added the test.

I would prefer if we just ignored numeric locale entirely, but in this case it would probably be enough to fix the test.

@faho faho added the bug Something that's not working as intended label Mar 15, 2020
@faho faho added this to the fish 3.2.0 milestone Mar 15, 2020
@faho faho closed this as completed in 4a9f524 Mar 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

1 participant