Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting the first character on a line continuation deletes the last character of the previous line #6951

Closed
fratajczak opened this issue Apr 27, 2020 · 4 comments
Labels
bug Something that's not working as intended
Milestone

Comments

@fratajczak
Copy link

fish version: 3.0.2-1627-gd502ad2c2 and up
Tested on Fedora 31 Linux pc 5.5.16-200.fc31.x86_64 #1 SMP Wed Apr 8 16:43:33 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
The problem seems to be caused by d502ad2, the bug occurs on both gnome-terminal and kitty with a vanilla fish config.

To reproduce:

  • Write a long command until the line wraps
  • Insert only 1 character on the new line
  • Press backspace
  • The last character of the previous line disappears, it reappears after a redraw.
@zanchey
Copy link
Member

zanchey commented Apr 27, 2020

That change got reworked in 5ece448 - can I ask if you've tried a newer version?

@fratajczak
Copy link
Author

Yes, I bisected from the master branch.

@zanchey zanchey added the bug Something that's not working as intended label Apr 27, 2020
@zanchey zanchey added this to the fish-future milestone Apr 27, 2020
@zanchey
Copy link
Member

zanchey commented Apr 27, 2020

Yes, and I can reproduce (sorry, it was so simple that I should have done that first)

@ridiculousfish
Copy link
Member

More fun from the sticky right margin. We can't issue clr_eos if we're "after" the last column since the cursor sticks to it. Fixed as 4116829 - thanks for filing!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants