Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting in fish 3.1.0, abbreviations no longer trigger with following semicolon #6970

lwolfsonkin opened this issue May 5, 2020 · 3 comments


Copy link

I was running fish 3.0.x previously and just upgraded to fish 3.1.0. I use a slew of abbr abbreviations for all the hg subcommands, and I used to make a chain by typing e.g. the literal amend; and upload which would expand to hg amend; and hg upload and each of amend and upload respectively would expand once I typed a following space, enter, or semicolon (at least among probably others).

Unfortunately, in 3.1.0, it no longer triggers. Is this intended? If not, is there a way for me to get the old behavior as long as I'm on this version?


@zanchey zanchey added this to the fish-future milestone May 5, 2020
Copy link

zanchey commented May 5, 2020

#5762 reduced the list of characters which expand abbreviations from " ;|&^><" to, by default, just space. Command execution always expands abbreviations under the cursor.

I think we probably want to put expansion back for all those other characters, though perhaps @faho can comment.

In the meantime, bind ';' self-insert expand-abbr should restore the behaviour you want - add it to your

Copy link

faho commented May 6, 2020

Yeah, it's probably fair to add the command terminators - ;, | and &.

I'm not sold on the redirection operators.

Copy link

zanchey commented May 7, 2020

My thinking is that if it would normally terminate a command then it should expand an abbreviation, so I'll add those back in.

@zanchey zanchey closed this as completed in ec74c73 May 7, 2020
@zanchey zanchey modified the milestones: fish-future, fish 3.2.0 May 7, 2020
@zanchey zanchey self-assigned this May 7, 2020
sudormrfbin added a commit to sudormrfbin/fish-shell that referenced this issue Jul 28, 2020
Abbr expansion on command terminators were added
back in ec74c73 in response to fish-shell#6970, but vi mode
was not updated.
krobelus pushed a commit that referenced this issue Jul 29, 2020
Abbr expansion on command terminators were added
back in ec74c73 in response to #6970, but vi mode
was not updated.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

3 participants