Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash state not shown with informative git prompt #7136

Closed
IlanCosman opened this issue Jun 20, 2020 · 1 comment
Closed

Stash state not shown with informative git prompt #7136

IlanCosman opened this issue Jun 20, 2020 · 1 comment
Labels
bug Something that's not working as intended
Milestone

Comments

@IlanCosman
Copy link
Contributor

IlanCosman commented Jun 20, 2020

fish, version 3.1.2
Linux archlabs 5.7.2-arch1-1 GNU/Linux

Run on clean fish:

ilan@archlabs ~> cd src/
ilan@archlabs ~/src (master)> git stash list
stash@{0}: WIP on master: b91c01e Initial commit
ilan@archlabs ~/src (master)> set -U __fish_git_prompt_showstashstate true
ilan@archlabs ~/src (master $)> #Shows stash state :)
ilan@archlabs ~/src (master $)> set -U __fish_git_prompt_show_informative_status true
ilan@archlabs ~/src (master|)> #Doesn't show stash state :(
ilan@archlabs ~/src (master|)> set -e __fish_git_prompt_showstashstate
ilan@archlabs ~/src (master|✔)> 

Reproduction is simple, just enter a git repository with stashed changes while __fish_git_prompt_showstashstate and __fish_git_prompt_show_informative_status are both set.

@faho faho closed this as completed in 894ec3d Jun 20, 2020
@faho
Copy link
Member

faho commented Jun 20, 2020

Yeah, this tried to be too clever.

Note that you very likely don't want the informative prompt - it's quite wasteful because it counts everything (including untracked and modified files, which can be super costly!).

If it's just because of the nicer symbols, use $__fish_git_prompt_use_informative_chars instead - I have been unable to convince people to make that the default, so we're stuck with remembering what on earth * was again.

@faho faho added the bug Something that's not working as intended label Jun 20, 2020
@faho faho added this to the fish 3.2.0 milestone Jun 20, 2020
ammgws added a commit to ammgws/dotfiles that referenced this issue Jun 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants