Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosuggestion is not shown (but completion does work) when line wraps to a newline #7213

Closed
Aster89 opened this issue Jul 20, 2020 · 4 comments
Labels
bug Something that's not working as intended
Milestone

Comments

@Aster89
Copy link
Contributor

Aster89 commented Jul 20, 2020

  • fish, version 3.1.2
  • Linux greywarden 5.7.9-arch1-1 Need a history built-in #1 SMP PREEMPT Thu, 16 Jul 2020 19:34:49 +0000 x86_64 GNU/Linux
  • rxvt-unicode (urxvt) v9.22 - released: 2016-01-23

To reproduce:

  1. Start to write a command, made up of several words, for which the full completion is longer than the width of the terminal;
  2. hit AltRight repeatedly to complete the entire line;
  3. you'll see that the ghost line disappears as soon as the partially completed line wraps at the terminal edge.

(The issue persists with sh -c 'env HOME=$(mktemp -d) fish'.)

asciicast

@ridiculousfish
Copy link
Member

I think this is saying that the autosuggestion disappears if fish chooses to lay out the command line below the prompt. I thought there was a reason for that but this comment suggestions it may not have been on purpose:

    // 5. Newline separator (left prompt visible, right prompt hidden, command line visible,
    // autosuggestion visible).

maybe we should show the autosuggestion in this case.

@ridiculousfish ridiculousfish added this to the fish-future milestone Jul 20, 2020
@faho
Copy link
Member

faho commented Jul 21, 2020

See also #5874.

@zanchey zanchey changed the title Ghost completion is not shown (but completion does work) when line wraps to a newline Autosuggestion is not shown (but completion does work) when line wraps to a newline Jul 21, 2020
@Aster89
Copy link
Contributor Author

Aster89 commented Jul 21, 2020

@faho , shouldn't the present issue be marked as enhancement too? I mean, it may be related to, but it's not the same as #5874.

@faho
Copy link
Member

faho commented Jul 21, 2020

@Aster89 It's not clear (well, to me, at least) whether this isn't just a symptom of the same underlying cause as #5874 yet, so it might just be a complete duplicate.

But at the end of the day the bug/enhancement labels don't matter all that much and the precise distinction often isn't easy or helpful. Duplicates are a bit more helpful because they allow us to focus on issues instead of looking at what turns out to be the same thing in multiple places.

@faho faho added the bug Something that's not working as intended label Sep 12, 2020
@faho faho modified the milestones: fish-future, fish 3.2.0 Sep 12, 2020
@faho faho closed this as completed in 5fd3ad6 Sep 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants