Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open.fish disown xdg-open on Awesome WM #7215

Closed
phamhm opened this issue Jul 21, 2020 · 5 comments
Closed

open.fish disown xdg-open on Awesome WM #7215

phamhm opened this issue Jul 21, 2020 · 5 comments

Comments

@phamhm
Copy link

phamhm commented Jul 21, 2020

  • fish version 3.1.2
  • Linux Fedora 32 5.7.8-200.fc32.x86_64.
  • Running Awesome WM.

xdg-open will fork a new process in XFCE but won't fork in Awesome Wm. I modified to my /usr/share/fish/functions/open.fish as follow to make open/xdg-open fork a new process.

            for i in $argv
                xdg-open $i &disown
            end
        else

Not sure if checking XDG_SESSION_DESKTOP to determine whether to disown would help.

@faho
Copy link
Member

faho commented Jul 21, 2020

I feel like whatever xdg-open is calling here is at fault - these things fork off new processes everywhere else, so this should as well.

Regardless, it's probably okay to just unconditionally background and disown these.

@faho faho added this to the fish 3.2.0 milestone Jul 21, 2020
@faho
Copy link
Member

faho commented Jul 21, 2020

Ah, okay, it's xdg-open's "generic" path causing the issue.

It's already open upstream as a bug - https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/158. No reaction in 9 months, development appears to essentially be dead, with one commit in the last 13 months.

Yeah, let's work around it.

@faho faho closed this as completed in 5b706fa Jul 21, 2020
@phamhm
Copy link
Author

phamhm commented Jul 21, 2020

Thank you for accepting this change request.

@krobelus
Copy link
Member

Just out of curiosity, setsid foo does essentially the same as foo & disown but I'm not sure if it is available on non-Linux?

@faho
Copy link
Member

faho commented Jul 21, 2020

The setsid command will not be available outside of linux, no.

(also if disown weren't fit for this we should fix it, this is its job)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants