Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abbr -e shouldn't error on unknown #7376

Closed
IlanCosman opened this issue Oct 3, 2020 · 0 comments
Closed

abbr -e shouldn't error on unknown #7376

IlanCosman opened this issue Oct 3, 2020 · 0 comments

Comments

@IlanCosman
Copy link
Contributor

IlanCosman commented Oct 3, 2020

~ ··············································································
❯ set -e blah                                                                   

~ ·········································································· ✘ 4
❯ abbr -e blah                                                                  
abbr --erase: No abbreviation named blah

~ ·········································································· ✘ 4
❯  

Why should abbr -e error on an unknown while set -e (and functions -e, though this has better reason) does not? Granted, the use cases are different. abbr is primarily used from the command line while set is primarily used in functions/scripts. But as stated in the the holy texts—the design docs—uniformity of language is to be praised.

@faho faho closed this as completed in 135c5a9 Oct 4, 2020
@zanchey zanchey added this to the fish 3.2.0 milestone Oct 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants