Skip to content

Create (empty) configuration directories and files on first run #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tadaboody opened this issue Oct 15, 2020 · 3 comments · Fixed by #7796
Closed

Create (empty) configuration directories and files on first run #7402

Tadaboody opened this issue Oct 15, 2020 · 3 comments · Fixed by #7796

Comments

@Tadaboody
Copy link

Tadaboody commented Oct 15, 2020

fish, version 3.1.0 (running OS X, tested on a ubuntu container to see the setup behaviour)

Completion scripts should go in ~/.config/fish/completions but that dir does not exist when starting to use fish, I think the process could be streamlined if it was created at setup (like .config/fish/ already is)

@IlanCosman
Copy link
Contributor

IlanCosman commented Oct 15, 2020

Neither is the conf.d directory, or the functions directory, or the config.fish file. It might help new users if those were all created, blank of course.

@Tadaboody Tadaboody changed the title Create .config/fish/completions dir on install Create (empty) configuration directories and files on install Oct 16, 2020
@krobelus krobelus added the RFC label Oct 18, 2020
@krobelus krobelus added this to the fish-future milestone Oct 18, 2020
@zanchey zanchey changed the title Create (empty) configuration directories and files on install Create (empty) configuration directories and files on first run Dec 30, 2020
@zanchey
Copy link
Member

zanchey commented Dec 30, 2020

This can't be done on install but rather on first run, but I think it's a reasonable idea - the base directories already get created anyway. Probably this could be done in __fish_config_interactive?

@krobelus
Copy link
Contributor

Yeah it seems fine. Many people might never use those directories but they don't hurt.

Compare to git init which creates plenty of example hooks in .git/hooks/.

@krobelus krobelus modified the milestones: fish-future, fish 3.3.0 Mar 23, 2021
@krobelus krobelus added enhancement and removed RFC labels Mar 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants