Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is being echoed before the prompt is ready #7489

rnhmjoj opened this issue Nov 19, 2020 · 2 comments

Text is being echoed before the prompt is ready #7489

rnhmjoj opened this issue Nov 19, 2020 · 2 comments


Copy link

rnhmjoj commented Nov 19, 2020

Unfortunately I have a rather slow prompt (can take >250ms) and it happens that I start typing text into the shell before the prompt is ready. This hasn't been an issue since fish would just delay the echo for a moment, until the prompt is printed.
Starting from 2a3677b, however, at least part of the text is printed immediately and duplicated:


This is not a big deal but it's a bit ugly. Is there something I can do (besides optimising the prompt) to revert to the previous behavior?

cc: @faho

Copy link
Contributor Author

rnhmjoj commented Nov 20, 2020

For the moment I came up with this:

function fish_greeting

It's not perfect because sometimes the text is still not cleared but it's something.

ridiculousfish added a commit that referenced this issue Nov 27, 2020
This prompt execution does not appear to be necessary, and spoils the
upcoming fix for #7489
Copy link

Let's move the call to set the tty to shell modes above the call to fish_prompt. This will make the prompt run with shell modes, but I feel confident in that change, because that's how fish worked prior to 2a3677b. Thanks for filing!

@ridiculousfish ridiculousfish added this to the fish 3.2.0 milestone Nov 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

No branches or pull requests

2 participants