Skip to content

normalize and document __fish_status_to_signal #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IlanCosman opened this issue Dec 31, 2020 · 2 comments · Fixed by #7597
Closed

normalize and document __fish_status_to_signal #7595

IlanCosman opened this issue Dec 31, 2020 · 2 comments · Fixed by #7597

Comments

@IlanCosman
Copy link
Contributor

I think that this is a case exactly like prompt_pwd, where Fish can offer a convenient service for those creating a prompt. I currently use this undocumented function in my prompt, Tide (well technically i'm using __fish_pipestatus_with_signal because this is before 293a3a6 is released).

@faho faho added this to the fish-future milestone Dec 31, 2020
@IlanCosman
Copy link
Contributor Author

Does the fish-future tag mean that the idea is accepted @faho? I'm happy to open a PR if that is the case.

@faho
Copy link
Member

faho commented Dec 31, 2020

Does the fish-future tag mean that the idea is accepted @faho? I'm happy to open a PR if that is the case.

"fish-future" means that it's something we'll add in "the future" - whenever that is. So it is accepted, yeah.

In contrast "fish-X.Y" means we'd like to work on it in that cycle, if possible, and "next-major" means it'll have to wait for the next major release - whenever that is. I didn't tag it as fish-3.2.0 because I don't think this should hold up the 3.2.0 release at this point.

@faho faho closed this as completed in #7597 Jan 3, 2021
@zanchey zanchey modified the milestones: fish-future, fish 3.2.0 Jan 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants