Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_config does not work in MacOS 11.2 Chrome or Firefox #7714

Closed
rr326 opened this issue Feb 14, 2021 · 9 comments
Closed

fish_config does not work in MacOS 11.2 Chrome or Firefox #7714

rr326 opened this issue Feb 14, 2021 · 9 comments
Milestone

Comments

@rr326
Copy link

rr326 commented Feb 14, 2021

fish_config works in Safari, but not Chrome or FireFox on MacOS 11.2.
In Safari, it looks just as it should.
In Chrome:

Screen Shot 2021-02-14 at 5 07 13 AM

No errors in developer console or network tabs.

Same thing in FireFox.

I'm fine since I can use Safari, but I thought you should know. Happy to help debug.

Environment

fish, version 3.1.2
Darwin xxx-imac-pro-7.localnet 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
xterm-256color
Could not do `sh -c 'env HOME=$(mktemp -d) fish'` - some other bug in my system, but this is a brand new fish install.
@zanchey
Copy link
Member

zanchey commented Feb 14, 2021

Do you get any output on the terminal where you started fish_config from?

@rr326
Copy link
Author

rr326 commented Feb 14, 2021

Web config started at file:///var/folders/yq/6wyn6yg100s6pgkfg2vtnr_80000gn/T/web_configs18ibs7m.html
Hit ENTER to stop.
$ set -L

Code gets echoed to the terminal every time I click on a new tab - like it's echoing locally. Not sure if that's abnormal.

@ridiculousfish ridiculousfish added this to the fish 3.2.0 milestone Feb 14, 2021
@ridiculousfish
Copy link
Member

ridiculousfish commented Feb 14, 2021

I am seeing Chrome hang (!!) when exiting the variables tab on macOS 11.1, Chrome 88. A sample shows it is spending all of its time in memmove. It occurs in fish 3.1.2 as well. Safari and Firefox work here.

This is probably a recent regression in Chrome, since I am sure we would have caught it by now. It may or may not be the same problem as this issue describes.

edit it's hanging due to the size of the history variable, I will add a commit to just omit that from the variables tab.

edit2: c35535d

@ridiculousfish
Copy link
Member

@rr326 I was not able to reproduce with fish 3.1.2 on macOS 11.2.1 with Firefox, Chrome, or Safari. Can you please check if the tabs (Prompt, Functions, etc) work? Is it possible you have a stylesheet which is taking precedence, or maybe an extension?

@jorgebucaran
Copy link

This could be related to microsoft/vscode#100840, adobe-fonts/source-code-pro#250, and the fix was to re-install Source Code Pro on macOS from here: https://github.com/adobe-fonts/source-code-pro/releases.

@faho
Copy link
Member

faho commented Feb 15, 2021

Yeah, that's the problem. On our end the best we can do is 768defe - not setting a specific font to try to avoid the Source Code Pro bug.

@rr326
Copy link
Author

rr326 commented Feb 15, 2021

I can confirm that it is indeed the color of the font that is the problem. (And yes, the tabs all work.) It sounds like you guys have it figured out.

@faho faho closed this as completed Feb 15, 2021
@faho
Copy link
Member

faho commented Feb 15, 2021

In that case I don't see anything else for us to do - we can only give the browser the html to render, and we can't really do anything about it misrendering it.

We'll try to not explicitly request the known-buggy font, but as far as I know there isn't a way to say "anything monospace except source code pro", and the real solution is for the font to be fixed.

ridiculousfish added a commit that referenced this issue Feb 15, 2021
The history variable may be so large that it hangs the browser, as
spotted in #7714. Omit this from the variable list.
@ridiculousfish
Copy link
Member

Awesome find @jorgebucaran

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants