Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal Variables + on-variable handlers borked #7774

Closed
IlanCosman opened this issue Mar 3, 2021 · 2 comments
Closed

Universal Variables + on-variable handlers borked #7774

IlanCosman opened this issue Mar 3, 2021 · 2 comments
Labels
regression
Milestone
fish 3.2.1

Comments

@IlanCosman
Copy link
Contributor

fish, version 3.2.0-12-ga36dbad3b For some reason I can only reproduce this on my Arch VM, and not my Ubuntu one running the exact same fish version.

Borked on Arch:
uvar_machine_broke

Working on Ubuntu 20.04:
uvar_machine_not_broke

@ridiculousfish probably internally screaming each time I open an issue 😂
@faho
Copy link
Member

faho commented Mar 3, 2021

Yeah, seems the SIGIO notifier is borked.

Honestly I'd probably just disable it entirely for 3.2.1.

@faho faho added the regression label Mar 3, 2021
@faho faho added this to the fish 3.2.1 milestone Mar 3, 2021
@faho faho closed this as completed in 791b42f Mar 3, 2021
@faho
Copy link
Member

faho commented Mar 3, 2021

Okay, sorry @ridiculousfish, I've disabled the SIGIO notifier for now.

We've had enough issues with it that I just don't trust it anymore.

@IlanCosman IlanCosman mentioned this issue Mar 3, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
fish 3.2.1
Development

No branches or pull requests
2 participants
@faho @IlanCosman