Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a function adds a comment line #7879

Closed
cycloss opened this issue Mar 30, 2021 · 1 comment
Closed

Editing a function adds a comment line #7879

cycloss opened this issue Mar 30, 2021 · 1 comment

Comments

@cycloss
Copy link

cycloss commented Mar 30, 2021

System Info:

Fish Version: 3.2.1
OS: macos Big Sur

Problem:

When using funced to edit a function with $EDITOR set to code -n -w or nano, a comment line is being added to the file where the function is defined along the lines of:

# Defined in /var/folders/l6/4wtwvg1903l93zlk1_5rzrzr0000gn/T//fish.43EOEP/dotupd.fish @ line 1

or if using funced -i:

# Defined Interactively

This didn't used to happen so I'm wondering if it's a feature of a new update? I'm not able to find any configuration info about it in the docs. I'd like to be able to turn this off as it changes every time I edit a function from the command line which makes my git commits messy. It's also noise that I'd rather not look at.

@faho faho closed this as completed in 18e3327 Mar 30, 2021
@faho faho added this to the fish 3.3.0 milestone Mar 30, 2021
@faho
Copy link
Member

faho commented Mar 30, 2021

Yeah I agree. I added a --no-details flag to functions to inhibit that comment, it's now used in funced.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants