Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish may hang on exit if another process is foreground #7901

Closed
ridiculousfish opened this issue Apr 5, 2021 · 2 comments
Closed

fish may hang on exit if another process is foreground #7901

ridiculousfish opened this issue Apr 5, 2021 · 2 comments
Assignees
Labels
bug Something that's not working as intended
Milestone

Comments

@ridiculousfish
Copy link
Member

On Mac, with fish 3.2.1: Launch fish, launch zsh from within fish, and then close the window. We will see that zsh exits but fish hangs.

fish is hanging because it is trying to assign the tty back to the original owner, but fish is not in control of the tty. Prior to the fix for #7060 this would have succeeded; but with #7060 we allow SIGTTOU, so we get SIGSTOP (which cannot be ignored).

@ridiculousfish ridiculousfish self-assigned this Apr 5, 2021
@ridiculousfish ridiculousfish added this to the fish 3.2.2 milestone Apr 5, 2021
@ridiculousfish
Copy link
Member Author

Fixed in 3.2.2 as fa890dc, master as ed51e2b

@zanchey
Copy link
Member

zanchey commented Apr 6, 2021

I couldn't reproduce this on Linux or FreeBSD, so I've noted it as macOS-only in the release notes.

@faho faho added the bug Something that's not working as intended label Apr 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants