Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function completion descriptions are overly wordy #7911

Closed
zx8 opened this issue Apr 8, 2021 · 1 comment
Closed

Function completion descriptions are overly wordy #7911

zx8 opened this issue Apr 8, 2021 · 1 comment

Comments

@zx8
Copy link

zx8 commented Apr 8, 2021

Consider the following scenario where I want to find a function I've defined that I know begins with __fish and has git somewhere in the name:

$ __fish_<tab>
# ctrl-s
# type "git"

Actual

image

None of these results are what I expect, because the description is being searched, which can contain all sorts of information that is irrelevant to the command I'm trying to recall.

Expected

Just commands that contain the exact substring "git".

@faho
Copy link
Member

faho commented Apr 8, 2021

No it should search the descriptions. That allows you to find more stuff, and is super helpful e.g. to find a git commit.

In this case the descriptions are overzealous - the entire definition helps nobody.

@faho faho changed the title ctrl+s to filter pager suggestions should not search descriptions Function completion descriptions are overly wordy Apr 8, 2021
@faho faho added this to the fish 3.3.0 milestone Apr 8, 2021
@faho faho closed this as completed in e2146a0 Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants