Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill "not enough arguments" possible regression #8046

Closed
bytefluxio opened this issue Jun 4, 2021 · 2 comments
Closed

kill "not enough arguments" possible regression #8046

bytefluxio opened this issue Jun 4, 2021 · 2 comments

Comments

@bytefluxio
Copy link

bytefluxio commented Jun 4, 2021

fish --version fish, version 3.2.2
echo $version 3.2.2

uname -a MSYS_NT-10.0-21390 DESKTOP-NE8TN2K 3.2.0-340.x86_64 2021-05-24 19:32 UTC x86_64 Msys
echo $TERM xterm-256color

Terminal: Windows Terminal, Version: 1.8.1521.0

Same issue with sh -c 'env HOME=$(mktemp -d) fish'


autocompletion seems to execute kill command before I'm done typing.


there doesn't seem to be an asciinema build compatible with msys2, so here's a screenshot:
WindowsTerminal_43B7PhWtaH

Might be a regression of #6469

@bytefluxio bytefluxio changed the title kill "not enough arguments" regression kill "not enough arguments" possible regression Jun 4, 2021
@faho
Copy link
Member

faho commented Jun 4, 2021

It's not a regression as there haven't been any changes to the completions since that time.

It's just that msys2 uses the same crappy kill implementation and we only check for cygwin.

I'm assuming uname says Msys, with a capital "M"?

@faho faho added this to the fish 3.3.0 milestone Jun 4, 2021
@bytefluxio
Copy link
Author

It does

@faho faho closed this as completed in 155160e Jun 5, 2021
@jtza8 jtza8 mentioned this issue May 9, 2022
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants