Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commandline -f repaint not responding to function handlers #8088

Closed
IlanCosman opened this issue Jun 28, 2021 · 4 comments
Closed

commandline -f repaint not responding to function handlers #8088

IlanCosman opened this issue Jun 28, 2021 · 4 comments
Labels
regression Something that used to work, but was broken, especially between releases
Milestone

Comments

@IlanCosman
Copy link
Contributor

fish, version 3.3.0-2-g210dda2c4

This is a regression from 3.2.2. Tested on Arch Linux and macOS.

function fish_prompt
    echo $PWD $foo
end

function on_foo --on-variable foo
    commandline -f repaint
end

The prompt will not update automatically, but pressing any key will update it.

repaint-not-working.mp4

The issue must be with repainting and not --on-variable, because this works:

function on_foo --on-variable foo
    echo $foo
end
on-variable-working.mp4
@IlanCosman IlanCosman changed the title commandline -f repaint not responding to variable handlers commandline -f repaint not responding to function handlers Jun 30, 2021
@douglascamata
Copy link

The "up key acting weirdly" part of this issue is very dangerous 😬

@krobelus krobelus added the regression Something that used to work, but was broken, especially between releases label Jul 3, 2021
@krobelus
Copy link
Member

krobelus commented Jul 3, 2021

Mea culpa, thanks for reporting! There should be a patch release with a fix soon.

@zanchey zanchey added this to the fish 3.3.1 milestone Jul 3, 2021
@IlanCosman
Copy link
Contributor Author

Can confirm this bug has been fixed on master.

Mea culpa, thanks for reporting! There should be a patch release with a fix soon.

Haha, no worries, it's a niche use case that I should have been actively monitoring before the release.

Thank you for the quick fix @krobelus 😄

@fish-shell fish-shell deleted a comment from freezlite Jul 6, 2021
@kidonng
Copy link
Contributor

kidonng commented Jul 18, 2021

It is reported that the offending commit is not fully reverted and there are still similar issues for some users.

@krobelus could you please investigate it?

krobelus added a commit that referenced this issue Jul 18, 2021
62d8f72 ("Revert "Avoid excessive polling of universal variable
file"") was not a complete revert, which seems to have caused the
problem reported in IlanCosman/tide#171.

See #8088
thunder-coding pushed a commit to thunder-coding/fish-shell that referenced this issue Jul 28, 2021
62d8f72 ("Revert "Avoid excessive polling of universal variable
file"") was not a complete revert, which seems to have caused the
problem reported in IlanCosman/tide#171.

See fish-shell#8088
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Something that used to work, but was broken, especially between releases
Projects
None yet
Development

No branches or pull requests

5 participants