Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vi mode indicator not updating on ctrl-c when in default mode #8103

Closed
SpikeTheMarmot opened this issue Jul 2, 2021 · 1 comment
Closed
Labels
bug Something that's not working as intended
Milestone

Comments

@SpikeTheMarmot
Copy link

$ fish --version
fish, version 3.2.2
$ echo $version
3.2.2
$ lsb_release -d
Description:	Arch Linux
$ uname -a
Linux marmot 5.12.13-arch1-2 #1 SMP PREEMPT Fri, 25 Jun 2021 22:56:51 +0000 x86_64 GNU/Linux
$ echo $TERM
xterm-kitty

Hey, I just enabled vi-mode for the first time and stumbled upon this little bug with the mode indicator.

If you are in normal/default mode and cancel the current input with ctrl-c the shell prints a new prompt in the next line as expected but does not update the mode indicator.
As far as I can tell this also happens in the newest version and I am pretty sure the problem is a missing repaint-mode in the following line:

bind -s --preset -m insert \cc cancel-commandline

After changing the line to

bind -s --preset -m insert \cc cancel-commandline repaint-mode

the mode indicator behaves as expected.

@SpikeTheMarmot SpikeTheMarmot changed the title Vi mode indicator not updating on ctrl-c Vi mode indicator not updating on ctrl-c when in default mode Jul 2, 2021
@zanchey
Copy link
Member

zanchey commented Jul 3, 2021

Nice find! I can reproduce in 3.3.0.

@zanchey zanchey added this to the fish 3.3.1 milestone Jul 3, 2021
@faho faho closed this as completed in 04af336 Jul 3, 2021
@faho faho added the bug Something that's not working as intended label Jul 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants