You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
$ fish --versionfish, version 3.3.1
$ echo$version3.3.1
$ lsb_release -dDescription: Arch Linux
$ uname -aLinux marmot 5.12.14-arch1-1 #1 SMP PREEMPT Thu, 01 Jul 2021 07:26:06 +0000 x86_64 GNU/Linux
$ echo$TERMxterm-kitty
Hey,
after further configuration of fish to my liking, I have discovered another bug with vi mode when using ctrl-c in default mode.
I use the following universal variables to change the appearance of the cursor in vi mode:
If you are in normal/default mode and cancel the current input with ctrl-c the shell prints a new prompt in the next line as expected but does not update the cursor shape. If I then go to normal mode and back into insert mode the issue resolves itself.
Apart from that the different cursor shapes have been working well so far.
I am not quite sure what's causing this problem, as fish_vi_cursor_handle should be executed on change of fish_bind_mode and fish_bind_mode actually changes (otherwise the mode prompt would not update correctly). #8103 might be relevant.
The text was updated successfully, but these errors were encountered:
Nice find! This is more or less the same as #6937: we're not clearing the cancel flag from control-C, so the event handler to change the cursor shape isn't running. I'll have a fix shortly.
When the user presses control-C, fish marks a cancellation signal which
prevents fish script from running, allowing it to properly unwind.
Prior to this commit, the signal was cleared in the reader. However this
missed the case where a binding would set $fish_bind_mode which would
trigger event handlers: the event handlers would be skipped because of
the cancellation flag was still set. This is similar to fish-shell#6937.
Let's clear the flag earlier, as soon as we it's set, in inputter_t.
Fixesfish-shell#8125.
When the user presses control-C, fish marks a cancellation signal which
prevents fish script from running, allowing it to properly unwind.
Prior to this commit, the signal was cleared in the reader. However this
missed the case where a binding would set $fish_bind_mode which would
trigger event handlers: the event handlers would be skipped because of
the cancellation flag was still set. This is similar to fish-shell#6937.
Let's clear the flag earlier, as soon as we it's set, in inputter_t.
Fixesfish-shell#8125.
Hey,
after further configuration of fish to my liking, I have discovered another bug with vi mode when using ctrl-c in default mode.
I use the following universal variables to change the appearance of the cursor in vi mode:
If you are in normal/default mode and cancel the current input with ctrl-c the shell prints a new prompt in the next line as expected but does not update the cursor shape. If I then go to normal mode and back into insert mode the issue resolves itself.
Apart from that the different cursor shapes have been working well so far.
I am not quite sure what's causing this problem, as
fish_vi_cursor_handle
should be executed on change offish_bind_mode
andfish_bind_mode
actually changes (otherwise the mode prompt would not update correctly). #8103 might be relevant.The text was updated successfully, but these errors were encountered: