Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove ephemeral history item with [space][return] #8232

Closed
timbertson opened this issue Aug 19, 2021 · 1 comment
Closed

Can't remove ephemeral history item with [space][return] #8232

timbertson opened this issue Aug 19, 2021 · 1 comment
Labels
bug Something that's not working as intended
Milestone

Comments

@timbertson
Copy link
Contributor

In 9fdc4f9, ephemeral history items were added.

One (subtle) feature is that this item is cleared if you type [space][return]. I want to use that feature, but it doesn't seem to work on my latest fish (v3.3.1). After doing that, the previous ephemeral item can still be recalled.

It looks like this behaviour was taken out here:

a427bf2

The behaviour and the comment describing it is removed, but there's seemingly no justification for actually changing this feature, the commit message implies it's just a crash-fix.

To reproduce:

# (command with leading space)
$  echo 1
1
# (solitary space)
$  
# (press the up arrow)
$  echo 1
1

$ fish --version
fish, version 3.3.1
$ uname -r
5.13.9-200.fc34.x86_64
@timbertson
Copy link
Contributor Author

/cc @faho in case you remember a427bf2

@faho faho closed this as completed in 70e3e0b Aug 20, 2021
@faho faho added the bug Something that's not working as intended label Aug 20, 2021
@faho faho added this to the fish 3.4.0 milestone Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants