Adds /bin to the end of the path unnecessarily #852

Closed
ghost opened this Issue Jun 3, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Jun 3, 2013

Recently, Arch Linux made a change where /bin and /sbin are now symlinked to /usr/bin. As a result, only /usr/bin is added to the PATH. fish then sees this PATH, freaks out that it doesn't have /bin, and adds /bin to the end, which is kind of odd.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jun 4, 2013

Member

I'm not against making the change suggested in #854, but can you explain what the current behaviour breaks? As far as I can see, the current code appends /bin to the existing path, and any overrides from ccache or similar should be prepended.

(Lots of OSes have /bin as a symlink to /usr/bin.)

Member

zanchey commented Jun 4, 2013

I'm not against making the change suggested in #854, but can you explain what the current behaviour breaks? As far as I can see, the current code appends /bin to the existing path, and any overrides from ccache or similar should be prepended.

(Lots of OSes have /bin as a symlink to /usr/bin.)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jun 4, 2013

...I actually just assumed that they broke and didn't check. You are correct; they don't break. I still agree with the change, though.

ghost commented Jun 4, 2013

...I actually just assumed that they broke and didn't check. You are correct; they don't break. I still agree with the change, though.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Aug 31, 2013

Member

In 85ce80d, I made setup_path not try to mess with the PATH unless it's entirely empty. I believe that should resolve this. Thanks for reporting this!

Member

ridiculousfish commented Aug 31, 2013

In 85ce80d, I made setup_path not try to mess with the PATH unless it's entirely empty. I believe that should resolve this. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment