Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job status message erased when using multiline prompt #8817

Closed
zanchey opened this issue Mar 19, 2022 Discussed in #8742 · 4 comments
Closed

Job status message erased when using multiline prompt #8817

zanchey opened this issue Mar 19, 2022 Discussed in #8742 · 4 comments
Assignees
Labels
bug Something that's not working as intended
Milestone

Comments

@zanchey
Copy link
Member

zanchey commented Mar 19, 2022

Discussed in #8742

Originally posted by lacygoill February 23, 2022
Consider this minimal prompt:

function fish_prompt
    printf '\n$ '
end

Written in /tmp/home/.config/fish/config.fish.

Start fish like this:

$ XDG_CONFIG_HOME=/tmp/home/.config fish

Finally, start a job:

$ sleep 1 &

When the job terminates, it writes a message on the terminal:

$ fish: Job 1, 'sleep 1 &' has ended

But most of the time, this message is automatically cleared (maybe 5 out of 6 times):

gif

The issue disappears if the newline is removed from the prompt.

Is there a way to prevent the message from being cleared?

I think this is another bug in multiline prompt handling.

@zanchey zanchey changed the title How to prevent ended job message from being cleared when using multiline prompt? Job status message erased when using multiline prompt Mar 19, 2022
@zanchey zanchey added the bug Something that's not working as intended label Mar 19, 2022
@zanchey zanchey added this to the fish-future milestone Mar 19, 2022
@ridiculousfish
Copy link
Member

Hunh, doesn't repro on iTerm2 or Terminal app, looks to be terminal specific.

@lacygoill
Copy link

On Ubuntu 20.04, I can reproduce in:

  • GNOME Terminal 3.36.2 using VTE 0.60.3 +BIDI +GNUTLS +ICU +SYSTEMD
  • kitty 0.24.4
  • st 0.8.4
  • xfce4-terminal 0.8.9.1 (Xfce 4.14)
  • XTerm(353)

@zanchey
Copy link
Member Author

zanchey commented Apr 3, 2022

I can't reproduce on Terminal.app when fish is running locally on macOS, but I can with mosh to a Linux session.

@krobelus krobelus self-assigned this Apr 9, 2022
@krobelus krobelus modified the milestones: fish-future, fish 3.5.0 Apr 9, 2022
@krobelus
Copy link
Member

krobelus commented Apr 9, 2022

fixed with 32ed0b8, thanks for reporting. Sadly the behavior is still flaky but it's just an occasional extra blank line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

4 participants