Valid commands following redirection symbols at command line start are colored as $fish_color_command instead of $fish_color_error

[schuelermine]

fish, version 3.4.1
3.4.1

Typing something like >echo doesn’t color the echo as an error, but it should

[schuelermine]

https://asciinema.org/a/487589

[neerajram30]

Hi there, is the issue solved ?

[schuelermine]

No

[neerajram30]

Can I work on solving this issue?

[faho]

@neerajram30 It's open and nobody has said they're working on it, so go for it!

[prady0t]

I would like to work on this.

[floam]

Sure, go ahead, it was nearly a month ago the other individual said they were interested in solving it.

[mikoreal]

I'm trying to solve this, however I have a bit of trouble finding how and in which files it's defined how colors are autosuggested based on validity of the commands. Could anyone provide any info on that?

[krobelus]

@mikoreal probably this can be fixed inside highlighter_t::visit(const ast::decorated_statement_t &stmt).
If a redirection's source_range occurs textually before the statement's command, then we should probably color at least the command token as error. The syntax tree nodes are defined in src/ast.h.

[NotHimmel]

@krobelus Thanks your guidance. I have submitted the PR for review. Could you please take a look when you have a chance? Thank you again! Link is #9587

[99jte]

May be in over my head with it (to my credit, it's still labeled a "good first issue"), but have there been any further thoughts on the options to solve this discussed in #9587 (comment) ?

[ridiculousfish]

No. Probably this should be fixed at the AST level: if we encounter an erroneous redirection, then try consuming the next token and if it's a string then pull that into the error range.