Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return to accept the first candidate after complete-and-search #9080

Closed
daanturo opened this issue Jul 20, 2022 · 3 comments
Closed

Allow return to accept the first candidate after complete-and-search #9080

daanturo opened this issue Jul 20, 2022 · 3 comments

Comments

@daanturo
Copy link
Contributor

After executing complete-and-search, the first completion candidate appears to be selected, but the "return"/"enter" key can't accept them.

I have to move around and back like "right" and "left", then "return" can now replace the input with the candidate.

@faho
Copy link
Member

faho commented Jul 20, 2022

If you mean the actual completion candidate that's shown in the pager and stuff, return will accept it by default.

If you mean the greyed-out bit of the commandline, that's the autosuggestion, and it's not accepted on purpose - because otherwise it's hard to not accept it.

If the former bit doesn't work, please try without any customization and post your fish version, like the issue template asks you to.

@daanturo
Copy link
Contributor Author

daanturo commented Jul 20, 2022

fish, version 3.4.1
TERM=xterm-256color
OS: Arch Linux

recording: asciinema recording
After typing pac, press backtab, I press Enter.

@faho
Copy link
Member

faho commented Jul 20, 2022

Ah, okay.

So your issue is that triggering complete-and-search immediately doesn't leave the first candidate selected.

That can probably be changed.

@krobelus krobelus added this to the fish 3.6.0 milestone Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants