New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions busted for nested subcommands #913

Closed
ridiculousfish opened this Issue Jul 17, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@ridiculousfish
Member

ridiculousfish commented Jul 17, 2013

echo (echo (echo fil<tab>

This doesn't work properly. The issue is that parse_util_locate_cmdsubst returns the outermost command substitution containing the cursor, not the innermost one.

@ghost ghost assigned ridiculousfish Jul 17, 2013

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jul 17, 2013

Member

Scary fix to make this behavior change, but it seems to work and all tests pass. Here we go.

Member

ridiculousfish commented Jul 17, 2013

Scary fix to make this behavior change, but it seems to work and all tests pass. Here we go.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish
Member

ridiculousfish commented Jul 17, 2013

Fixed as 1511de6

haarts pushed a commit to haarts/fish-shell that referenced this issue Nov 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment