Completions for relative path are loaded even if the command isn't available in $PATH

[Qix-]

fish, version 3.5.1

Yes, this happens in a clean environment.

I manage my Github clones with a script called gh, which I invoke via ./gh foo/bar.

Fish seems to think I'm trying to run the global gh command, which is not the case - I don't use Github's client but I suppose theirs is similarly named gh.

Whenever I write ./gh foo/bar, I get the error message:

/opt/homebrew/Cellar/fish/3.5.1/share/fish/completions/gh.fish (line 1):
gh completion --shell fish 2>/dev/null | source
^
from sourcing file /opt/homebrew/Cellar/fish/3.5.1/share/fish/completions/gh.fish

Shouldn't it be seeing that I'm writing ./gh and not gh and ignore it?

[faho]

Quite simply put: It is impossible for us to tell that your command isn't the same "gh" that we know how to complete. It is also correct for us to interpret absolute or relative paths the same - imagine if you ran ./git.

Sorry, there is nothing we can do here. Rename your script or replace the completions by putting a file in ~/.config/fish/completions called "gh.fish".

[faho]

Duplicate of #9001

[Qix-]

Err, no it's not. This is not added to my path. This is a local file in the CWD being run. gh is not the same as ./gh. That is my point.

At the very least, the completion manager should be checking to see if the thing it's running is actually on the PATH. It just assumes it does, hence the error message.

This is a bug in fish.

[faho]

That's #3117

But regardless, we would try to complete your thing like Github's gh, and that wouldn't work, because it's not that gh. And that's not fixable.

[Qix-]

Is it that difficult to do "if this command isn't querying a PATH command, don't issue completions for it"?

Why would I ever want completions on local scripts? Is there a way to disable this behavior?

And if it's "impossible" how do I turn off completions entirely?

[faho]

Is it that difficult to do "if this command isn't querying a PATH command, don't issue completions for it"? Why would I ever want completions on local scripts?

It was a bug that it didn't, so we enabled it (#6001 and then #8442). It's typically the right thing, e.g. when I do /usr/bin/git, or when I do ./fish.

And because names mean things, something that's called "git" should complete like "git", something that's named "rm" should complete like "rm".

Is there a way to disable this behavior?

There is no global toggle. You can disable the completion script for gh by creating an empty completion script - touch ~/.config/fish/completions/gh.fish. Like I said in my first comment.

And if it's "impossible" how do I turn off completions entirely?

You don't.

Well, I guess you could clear $fish_complete_path? That'll leave you with file completions for basically everything.

[faho]

Okay, here's what we can do:

We already don't load completions for commands that don't exist, to avoid errors. We can extend that to not load completions for commands that don't exist in $PATH (or as a function/builtin).

That won't fix your completions, because you still have something called "gh" that's not the "gh" we know, but it will remove the error even without fixing #3117 (which we're not even sure how).

If you ever installed gh completing ./gh would give the wrong completions, and if we fixed #3117 it would call your ./gh with bogus arguments - because we can't know that it's not that "gh".

---

One more thing I'd love to know is if your error doesn't mention that the command wasn't found or if you just missed that line when copying. That threw me off here.