Skip to content

Custom git command completion seems to be broken in 3.6 #9457

@jaminthorns

Description

@jaminthorns

The new 3.6 release is fantastic! Upon upgrading, though, I noticed that completions for my custom git commands are no longer working. I have a few commands that augment certain git commands, and I get completions for them by wrapping their corresponding git commands using the -w flag (previously discussed here). I have these completions set in a conf.d file:

complete -c git-branches -w "git branch"
complete -c git-branches -s o -l graph-options -d "Options for the 'git graph' view"

complete -c git-compare -w "git diff"
complete -c git-compare -s p -l path -d "Show only changes from specified path"

complete -c git-history -w "git log"
complete -c git-history -s p -l path -d "Show only commits and changes from specified path"
complete -c git-history -s o -l show-options -d "Options for the 'git show' view"

complete -c git-stashes -w "git stash"
complete -c git-history -s o -l stash-show-options -d "Options for the 'git stash show' view"

complete -c git-view -w "git show"
complete -c git-view -s p -l path -d "Show only changes from specified path"

These completions don't seem to work at all anymore. My guess is that it might be due to the recent change for caching commands in share/completions/git.fish.

Metadata

Metadata

Assignees

No one assigned

    Labels

    regressionSomething that used to work, but was broken, especially between releases

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions