Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+g should quit the history search #9484

Closed
pierrelegall opened this issue Jan 17, 2023 · 2 comments
Closed

Ctrl+g should quit the history search #9484

pierrelegall opened this issue Jan 17, 2023 · 2 comments

Comments

@pierrelegall
Copy link

pierrelegall commented Jan 17, 2023

In the new history search of Fish 3.6, Ctrl+g do nothing. However, in shells like Bash or Zsh, it quits the history search.

If fact, Ctrl+j already do the job. But you know, muscle memory...

Current behavior

Ctrl+g do nothing in the history search.

Expected behavior

Ctrl+g quits the history search.

Congrats

Fish version 3.6 is awesome, good job to the team!

@krobelus
Copy link
Member

I think Escape (or Control-[) has this behavior - it restores the command before history search (or are you looking to keep the search query?)
Today you can add a binding using bind \cg cancel.
I'm sympathetic towards adding this binding by default because it's a well-known Emacs chord.

If fact, Ctrl+j already do the job

this does something slightly different, it accepts the selected history item

@pierrelegall
Copy link
Author

Same behavior as Escape is perfect from my point of view ;)

@pierrelegall pierrelegall changed the title Ctrl+g should quits the history search, keeping the actual typed command unchanged Ctrl+g should quits the history search Jan 17, 2023
@faho faho closed this as completed in 01d6810 Jan 21, 2023
@faho faho added this to the fish 3.6.1 milestone Jan 21, 2023
@krobelus krobelus changed the title Ctrl+g should quits the history search Ctrl+g should quit the history search Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants