Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__fish_print_help should respect $MANPAGER #9488

Closed
ian-h-chamberlain opened this issue Jan 18, 2023 · 1 comment
Closed

__fish_print_help should respect $MANPAGER #9488

ian-h-chamberlain opened this issue Jan 18, 2023 · 1 comment

Comments

@ian-h-chamberlain
Copy link
Contributor

It seems that builtins' --help argument seems to display differently than usual man commands:

# Seems to just use my default $PAGER instead of $MANPAGER
MANPAGER='sh -c "col -bx | bat -plman"' printf --help

vs

# Does what I expect
MANPAGER='sh -c "col -bx | bat -plman"' man printf

Since the builtins use the same man-style output it would make sense to use $MANPAGER first, perhaps falling back to $PAGER if unset.

Originally posted by @ian-h-chamberlain in #2170 (comment)

@faho
Copy link
Member

faho commented Jan 18, 2023

Note: printf is a bad example because that's actually not supposed to take any options, and we've fixed that in 3.6.0 - #9132.

(ideally we'd do what we do for e.g. begin --help and print the help if that's literally the command, but that's a bigger thing)

@faho faho added this to the fish 3.6.1 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants