Display only stash count

[Dreamsorcerer]

I'd like to be able to display just the stash count, but the current version of fish seems to have broken this (it mostly worked on 3.1, which is the version installed on Ubuntu 20.04).

If I do:

set -U __fish_git_prompt_show_informative_status 1
set -U __fish_git_prompt_showstashstate 1
set -U __fish_git_prompt_status_order stashstate

Then the count will not be displayed. I think that's because this disables the informative status entirely:
https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_git_prompt.fish#L259-L265

Additionally, I'd also point out that it was a little confusing when setting these variables, as to why there were global variables shadowing them. It seems the script sets a global variable if it's not already set, not sure if maybe that should be changed to a local variable to be less confusing?
https://github.com/fish-shell/fish-shell/blob/master/share/functions/fish_git_prompt.fish#L229

[Dreamsorcerer]

Wrote a test in #9573 to reproduce it.

Just realised that the variable has also been renamed since then too (2 underscores instead of 3 now).

[faho]

Just realised that the variable has also been renamed since then too (2 underscores instead of 3 now).

I'm reasonably sure it hasn't been. The version with 3 underscores is the cached "effective" version.

The git prompt has a bunch of knobs that influence each other, and so we save the result in a separate variable.

Then the count will not be displayed. I think that's because this disables the informative status entirely:

This disables the informative status because that is extremely slow in larger repositories because it needs to call git status to count all files, as opposed to git calls that can quit early once they found something. So we disable it if the status call isn't necessary, to avoid people getting prompts that are slow by doing useless work.

It would be possible to still count the cache. This would require a change to the non-informative path.

[Dreamsorcerer]

Just realised that the variable has also been renamed since then too (2 underscores instead of 3 now).

I'm reasonably sure it hasn't been. The version with 3 underscores is the cached "effective" version.

Hmm, on my Ubuntu 20.04 machine setting the variable with 2 underscores does nothing (I ensured both versions were erased first), while on the Mac setting the one with 3 underscores does nothing...

Though I'm still having issues with the default value appearing as a global variable from time to time, and then shadowing my setting...

It would be possible to still count the cache. This would require a change to the non-informative path.

OK, that sounds reasonable. I'll see if I can figure out a fix then.

[faho]

Hmm, on my Ubuntu 20.04 machine setting the variable with 2 underscores does nothing (I ensured both versions were erased first), while on the Mac setting the one with 3 underscores does nothing...

Ah, now I know what you mean. I was thinking of __fish_git_prompt_showstashstate, you're talking about the status order.

The latter was indeed renamed in a659335 - before it was considered an implementation detail.

However: The version shipped in Ubuntu 20.04 is fish 3.1.0 (not even 3.1.2, the bugfix release!). It is 3 years out of date and missing 5167 commits that are in 3.6.0. That's 31.1% of all commits ever made to fish. It's basically so different that talking about it isn't really worth it.

[Dreamsorcerer]

Yeah, it was just a comment on what I observed. (downstream packagers tend to fix to a specific release, but often backport some fixes, so it may well have some of the fixes from 3.1.2, even without the version number)

[faho]

downstream packagers tend to fix to a specific release, but often backport some fixes, so it may well have some of the fixes from 3.1.2, even without the version number

(it does not. fish is in Ubuntu's "universe" section, which means it's a straight import from Debian months before the release and entirely unmaintained after)