Skip to content

completions: zfs completions broken due to read-only variable #9705

Closed
Closed
completions: zfs completions broken due to read-only variable#9705
Labels
bugSomething that's not working as intendedcompletions
Milestone
fish 3.7.0

Description

@ammgws
ammgws
opened on Apr 3, 2023
# fish --version
fish, version 3.6.1
# zfs load-key r[TAB]: _: cannot overwrite read-only variable
/usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12): 
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments 'feature@bookmarks'
	called on line 344 of file /usr/share/fish/completions/zfs.fish
from sourcing file /usr/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)
read: _: cannot overwrite read-only variable
/usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12): 
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments 'feature@bookmarks'
	called on line 508 of file /usr/share/fish/completions/zfs.fish
from sourcing file /usr/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)
read: _: cannot overwrite read-only variable
/usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 12): 
    echo $feature_name | read -l _ _ state _
    ^
in function '__fish_is_zfs_feature_enabled' with arguments 'feature@extensible_dataset'
	called on line 548 of file /usr/share/fish/completions/zfs.fish
from sourcing file /usr/share/fish/completions/zfs.fish

(Type 'help read' for related documentation)

Activity

  1. ammgws commented on Apr 3, 2023

    @ammgws
    ammgws
    on Apr 3, 2023
    ContributorAuthor

    Huh, seems like this was coincidentally fixed in 85504ca but seems like that didn't make the cut for the 3.6.1 release.

  2. zanchey
    changed the title [-]completions: zsh completions broken due to read-only variable[/-] [+]completions: zfs completions broken due to read-only variable[/+] on Apr 3, 2023
  3. faho
    added this to the fish 3.6.2 milestone on Apr 3, 2023
  4. faho
    added
    enhancement
    completions
    on Apr 3, 2023

  5. faho commented on Apr 3, 2023

    @faho
    faho
    on Apr 3, 2023
    Member

    Closing this with a 3.6.2 milestone so we'd add it if we make a 3.6.2 release - other than that it's already fixed so the next full release will include it.

    I do consider this to be a good reason to cut a 3.6.2 release, fwiw.

  6. faho
    closed this as completedon Apr 3, 2023
  7. faho
    added
    bugSomething that's not working as intended
    and removed
    enhancement
    on Apr 3, 2023

  8. bakhtiyarneyman commented on Jun 3, 2023

    @bakhtiyarneyman
    bakhtiyarneyman
    on Jun 3, 2023

    Will there be a 3.6.2?

  10. bentolor commented on Jul 30, 2023

    @bentolor
    bentolor
    on Jul 30, 2023

    @broizter I've adopted the patch mentioned above, but I still get on history search:

    ~  zfs create z0tank/games -o mountpoint=/home/ben/G/usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish (line 8): Expected end of the statement, but found an incomplete token                                                                                                 So 30 Jul 2023 11:13:39 CEST
        set feature_name (zpool get -H all $pool 2>/dev/null | string match -r "$pool\s$feature\s")
                                                                                                 ^
from sourcing file /usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish
	called on line 1 of file /usr/share/fish/completions/zfs.fish
from sourcing file /usr/share/fish/completions/zfs.fish
source: Error while reading file '/usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish'
__fish_is_zfs_feature_enabled: Befehl nicht gefunden.
/usr/share/fish/completions/zfs.fish (line 344): 
if __fish_is_zfs_feature_enabled 'feature@bookmarks'
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /usr/share/fish/completions/zfs.fish
__fish_is_zfs_feature_enabled: Befehl nicht gefunden.
/usr/share/fish/completions/zfs.fish (line 508): 
if __fish_is_zfs_feature_enabled 'feature@bookmarks'
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /usr/share/fish/completions/zfs.fish
__fish_is_zfs_feature_enabled: Befehl nicht gefunden.
/usr/share/fish/completions/zfs.fish (line 548): 
if __fish_is_zfs_feature_enabled "feature@extensible_dataset"
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /usr/share/fish/completions/zfs.fish
ame                                                      s                                                                                                                                                                                                                                ```

Any hints?

  11. TwoD commented on Sep 14, 2023

    @TwoD
    TwoD
    on Sep 14, 2023

    Note that the comment above has a linewrap issue.
    The first line should be exactly this:
    function __fish_is_zfs_feature_enabled -a feature target -d "Returns 0 if the given ZFS feature is available or enabled for the given full-path target (zpool or dataset), or any target if none given"
    and the second line begins with (indented) set -l pool

  12. billimek
    added a commit that references this issue on Oct 7, 2023

    Patching fish to temp fix [this issue](fish-shell/fish-shell#9705)

    eb7244b

  13. luispabon commented on Dec 8, 2023

    @luispabon
    luispabon
    on Dec 8, 2023

    I am getting this problem on 3.6.4 on Ubuntu 23.10 (official ppa):

    image

    These are the contents of the file in question:

    function __fish_is_zfs_feature_enabled -a feature target -d "Returns 0 if the given ZFS feature is available or enabled for the given full-path target (zpool or dataset), or any target if none given"
    set -l pool (string replace -r '/.*' '' -- $target)
    set -l feature_name ""
    if test -z "$pool"
        set feature_name (zpool get -H all 2>/dev/null | string match -r "\s$feature\s")
    else
        set feature_name (zpool get -H all $pool 2>/dev/null | string match -r "$pool\s$feature\s")
    end
    if test $status -ne 0 # No such feature
        return 1
    end
    echo $feature_name | read -l _ _ state _
    set -l state (echo $feature_name | cut -f3)
    string match -qr '(active|enabled)' -- $state
    return $status
end

    Doesn't seem like 85504ca is in there

  14. bentolor commented on Dec 8, 2023

    @bentolor
    bentolor
    on Dec 8, 2023

    Similar to @luispabon I get the same error after upstream update from PPA to 3.6.4.

    Obviously I patched /usr/share/fish/functions/__fish_is_zfs_feature_enabled.fish manually before as described in the comments, but it seems to have been overwritten again with a broken version.

  15. luispabon commented on Dec 8, 2023

    @luispabon
    luispabon
    on Dec 8, 2023

    There might be an issue with the ppa's packaging, the file in the repo is completely different to the file installed by the .deb on the ppa:

    https://github.com/fish-shell/fish-shell/blob/3.6.4/share/functions/__fish_is_zfs_feature_enabled.fish

    The above was wrong, the file in 3.6.4 master is completely different to this here file in master:

    https://github.com/fish-shell/fish-shell/blob/master/share/functions/__fish_is_zfs_feature_enabled.fish

    Looks like the changes were merged back in august to master, perhaps 3.6.x releases from a branch instead?

  16. bentolor commented on Dec 8, 2023

    @bentolor
    bentolor
    on Dec 8, 2023

    @luispabon You're right: 85504ca is only in master while the last commit of 3.6.4 before release b2ef44a is in Integration_3.6.4 and Integration_3.7.0.

    It seems 3.6.x and 3.7.x are not including the fix yet. Not sure how the team cherry-picks/selects what goes into which integration branch.

  17. luispabon commented on Dec 8, 2023

    @luispabon
    luispabon
    on Dec 8, 2023

    I've replaced my local file for the one in master and seems to be working fine.

  18. ammgws commented on Dec 9, 2023

    @ammgws
    ammgws
    on Dec 9, 2023
    ContributorAuthor

    @zanchey FYI for next release

  19. zanchey commented on Dec 23, 2023

    @zanchey
    zanchey
    on Dec 23, 2023
    Member

    2c460cd looks like it's in Integration_3.7.0, am I missing something?

  20. github-actions
    locked as resolved and limited conversation to collaborators on Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething that's not working as intendedcompletions

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions