`Ctrl+R` behavior when no matches: cancelled command

[jerrygreen]

In normal bash, when no results found while using reverse-i-search (Ctrl+R), you still able to run the command you started to type.

In fish, if search fails, pressing enter just cancels the search.

I think fish should stick to bash behavior in here, – actually execute command on pressing Enter.

After all, if user wants to cancel his command, he can always press Ctrl+C.

There's no need to duplicate this behavior for Enter, basically removing other useful functionality.

[krobelus]

makes sense, good find

[josharsh]

Hey
Is this issue still open and up for grabs?
May I pick it?

@zanchey @faho @uggedal @krobelus @jerrygreen

[faho]

Is this issue still open and up for grabs?

As far as I know, yeah.

May I pick it?

Go right ahead!

---

However, @josharsh: Please don't tag random people in your comment.

[krobelus]

I don't think it should execute directly but only copy the search field text to the commandline, to be consistent with successful matches

[jerrygreen]

I don't think it should execute directly but only copy the search field text to the commandline, to be consistent with successful matches

100% true. I didn't mean to execute it right away. You're completely right in this one. Consistency is important

UPD. on the second thought though, it might be a good thing to change this double-enter Ctrl+R behavior in overall, that's a bit off the current issue so I created discussion there:

• `Ctrl+R` Immediate command execution – What do you think? #9938

May I pick it?

❤