Run fish_update_completions automatically after installation through packages #997

Closed
siteshwar opened this Issue Sep 11, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@siteshwar
Member

siteshwar commented Sep 11, 2013

fish_update_completions script is not being run after installing fish through Linux and OS X packages. This means that user would not get completions that can be generated through this command. Should it be run by default after installing fish through packages ?

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 12, 2013

Member

Sounds like a good idea. fish_update_completions is probably the wrong command as that only works for home directories, and we have to be careful in packages about creating files that we then don't remove.

Member

zanchey commented Sep 12, 2013

Sounds like a good idea. fish_update_completions is probably the wrong command as that only works for home directories, and we have to be careful in packages about creating files that we then don't remove.

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Sep 12, 2013

Member

So should we write output of fish_update_completions in $__fish_datadir/generated_completions while installing package and append this directory to fish_complete_path ?

Member

siteshwar commented Sep 12, 2013

So should we write output of fish_update_completions in $__fish_datadir/generated_completions while installing package and append this directory to fish_complete_path ?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 13, 2013

Isn't this the job of package maintainers and not the job of fish, though?

ghost commented Sep 13, 2013

Isn't this the job of package maintainers and not the job of fish, though?

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Sep 13, 2013

Member

We distribute packages (and in fact most of my work on fish recently has been the packaging infrastructure), and our packages should demonstrate "best practice" which would include using all the features of fish in a way that is consistent with packaging guidelines.

Member

zanchey commented Sep 13, 2013

We distribute packages (and in fact most of my work on fish recently has been the packaging infrastructure), and our packages should demonstrate "best practice" which would include using all the features of fish in a way that is consistent with packaging guidelines.

@siteshwar

This comment has been minimized.

Show comment
Hide comment
@siteshwar

siteshwar Mar 3, 2014

Member

Since 0f02997 fish_update_completions is automatically run at startup if the directory which contains generated completions does not exist. Closing this issue !

Member

siteshwar commented Mar 3, 2014

Since 0f02997 fish_update_completions is automatically run at startup if the directory which contains generated completions does not exist. Closing this issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment