Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fish_update_completions automatically after installation through packages #997

Closed
siteshwar opened this issue Sep 11, 2013 · 5 comments
Closed

Comments

@siteshwar
Copy link
Member

@siteshwar siteshwar commented Sep 11, 2013

fish_update_completions script is not being run after installing fish through Linux and OS X packages. This means that user would not get completions that can be generated through this command. Should it be run by default after installing fish through packages ?

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 12, 2013

Sounds like a good idea. fish_update_completions is probably the wrong command as that only works for home directories, and we have to be careful in packages about creating files that we then don't remove.

@siteshwar
Copy link
Member Author

@siteshwar siteshwar commented Sep 12, 2013

So should we write output of fish_update_completions in $__fish_datadir/generated_completions while installing package and append this directory to fish_complete_path ?

@ghost
Copy link

@ghost ghost commented Sep 13, 2013

Isn't this the job of package maintainers and not the job of fish, though?

@zanchey
Copy link
Member

@zanchey zanchey commented Sep 13, 2013

We distribute packages (and in fact most of my work on fish recently has been the packaging infrastructure), and our packages should demonstrate "best practice" which would include using all the features of fish in a way that is consistent with packaging guidelines.

@siteshwar
Copy link
Member Author

@siteshwar siteshwar commented Mar 3, 2014

Since 0f02997 fish_update_completions is automatically run at startup if the directory which contains generated completions does not exist. Closing this issue !

@siteshwar siteshwar closed this Mar 3, 2014
@siteshwar siteshwar modified the milestones: next-minor, fish-future Mar 3, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.