Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions: add smerge (Sublime Merge CLI tool) #10135

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

zgracem
Copy link
Contributor

@zgracem zgracem commented Dec 5, 2023

Description

Adds completions for smerge, Sublime Merge's CLI.

TODOs:

  • [N/A] Changes to fish usage are reflected in user documentation/manpages.
  • [N/A] Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

complete -c smerge -l safe-mode -d 'Launch in a sandboxed environment'
complete -c smerge -s h -l help -d 'Show help (this message) and exit'
complete -c smerge -s v -l version -d 'Show version and exit'
complete -c smerge -a search -x -d 'Search for commits in the current repository'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about suggesting commits like here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that would be useful. The expected argument to search is a query string; the subcommand launches Sublime Merge with its argument pre-filled into the commit message search field, which doesn't search commit hashes.

@faho faho added this to the fish 3.7.0 milestone Dec 10, 2023
@faho faho merged commit b7a85fe into fish-shell:master Dec 10, 2023
@faho
Copy link
Member

faho commented Dec 10, 2023

Thanks!

@zgracem zgracem deleted the completions-smerge branch December 10, 2023 21:25
shouya pushed a commit to shouya/fish-shell that referenced this pull request Dec 29, 2023
* completions: add smerge (Sublime Merge CLI tool)

* completions: add `-o` (and file completion) to `smerge mergetool`
zanchey pushed a commit that referenced this pull request Dec 31, 2023
* completions: add smerge (Sublime Merge CLI tool)

* completions: add `-o` (and file completion) to `smerge mergetool`

(cherry picked from commit b7a85fe)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants