fish_vi_key_bindings: add bindings for semicolon and comma in visual mode#10601
Merged
faho merged 1 commit intofish-shell:masterfrom Oct 3, 2024
Merged
Conversation
…mode They are already presented in normal mode, and I presume were forgotten to be added in visual mode I don't add it to ./CHANGELOG.rst because it's a minor change that can be considered as a bug fix
Contributor
Author
|
The original commit that added It only added them in normal mode, I think it was a simple oversight, and they were not added to visual by mistake |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fish_vi_key_bindings: add bindings for semicolon and comma in visual mode
They are already presented in normal mode, and I presume were forgotten to be added in visual mode
TODOs:
No need to. It's expected to work out of the box
It's not a regression (at least, I'm not aware of)
I don't add it to
./CHANGELOG.rstbecause it's a minor change that can be considered as a bug fix