New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proc/pid completion in OS X #129

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bobthecow

bobthecow commented Jun 14, 2012

No description provided.

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jun 15, 2012

Member

I'd love to get these completions working with OS X, but I see a few problems with these changes:

  • pgrep is not installed by default on OS X
  • __fish_complete_proc doesn't seem to return many processes. (I think you need to pass -x to ps)

Please address these, and I'll be glad to merge.

Member

ridiculousfish commented Jun 15, 2012

I'd love to get these completions working with OS X, but I see a few problems with these changes:

  • pgrep is not installed by default on OS X
  • __fish_complete_proc doesn't seem to return many processes. (I think you need to pass -x to ps)

Please address these, and I'll be glad to merge.

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Aug 1, 2012

Now that it's the future, both of your concerns should have been resolved. Can we merge it now? :)

bobthecow commented Aug 1, 2012

Now that it's the future, both of your concerns should have been resolved. Can we merge it now? :)

@ridiculousfish

This comment has been minimized.

Show comment
Hide comment
@ridiculousfish

ridiculousfish Jan 16, 2013

Member

I ended up fixing these a different way. Commit is 6416cb4

Member

ridiculousfish commented Jan 16, 2013

I ended up fixing these a different way. Commit is 6416cb4

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow commented Jan 16, 2013

Sweet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment