Vagrant completion updates

[zzamboni]

Improved vagrant completions for some commands to avoid spurious completions, and added completions for some missing Vagrant commands.

[kballard]

Actually the whole function can be simplified again:

function __fish_vagrant_using_subcommand --arguments cmd_main cmd_sub
    set -l cmd (commandline -opc)
    set -q cmd[3]; and test "$cmd_main" = $cmd[2] -a "$cmd_sub" = $cmd[3]
end

Looks like the if [ $cmd_main ... command was actually wrong to begin with, since it was using an ; and in the condition without a begin/end block. Which is to say, it was never actually testing that the subcommand was correct.

[zzamboni]

Ooooh, this is the reason why the --provider flag was being offered as a completion to all the box subcommands! I wondered about that but never caught the mistake. Thanks!

[zzamboni]

And I just noticed the --arguments - very nice! Much cleaner than the usual shell way of fetching arguments.

[kballard]

Eh, when it works. It's basically equivalent to just

set -l cmd_main $argv[1]
set -l cmd_sub $argv[2]

except without array out of bound index errors.

But if you need to conditionally parse out flags or suchlike, it can end up being more annoying to work with than just $argv.

[kballard]

Squashed and pushed as d982f2a. Thanks!

[kballard]

Squashed and pushed as d982f2a. Thanks!

[zzamboni]

Thanks!

[zzamboni]

Thanks!