New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setfacl completions #1752

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rominf
Contributor

rominf commented Oct 12, 2014

Due to some reasons setfacl --modify TAB doesn't work. fish version is 2.1.0. Is this a bug or my misunderstanding of complete function?

Is there better way to add several arguments completion to several options?

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Oct 19, 2014

Member

It's generally best to use sgrep from within completions, as grep may not behave as expected.

Member

zanchey commented Oct 19, 2014

It's generally best to use sgrep from within completions, as grep may not behave as expected.

@rominf

This comment has been minimized.

Show comment
Hide comment
@rominf

rominf Oct 19, 2014

Contributor

I've never heard about it. Is it portable (and preinstalled on OS X, BSD, etc.)?

It it OK now?

Contributor

rominf commented Oct 19, 2014

I've never heard about it. Is it portable (and preinstalled on OS X, BSD, etc.)?

It it OK now?

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Oct 21, 2014

Member

It's defined by fish, for use in completions etc. This looks like a good start - I've merged it with a squash merge here:

To git@github.com:fish-shell/fish-shell.git
3fe1069..cfa4168 master -> master

Thanks!

Member

zanchey commented Oct 21, 2014

It's defined by fish, for use in completions etc. This looks like a good start - I've merged it with a squash merge here:

To git@github.com:fish-shell/fish-shell.git
3fe1069..cfa4168 master -> master

Thanks!

@zanchey zanchey closed this Oct 21, 2014

@zanchey zanchey added this to the next-minor milestone Oct 21, 2014

@zanchey zanchey self-assigned this Oct 21, 2014

@rominf rominf deleted the rominf:setfacl-completions branch Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment