Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve systemctl completions #1950

Closed
wants to merge 12 commits into from
Closed

Improve systemctl completions #1950

wants to merge 12 commits into from

Conversation

@faho
Copy link
Member

@faho faho commented Feb 19, 2015

This adds support for user-mode and fixes an assumption - in systemctl, options can come before commands.

systemctl --user status works, as does --quiet or --all.

Fixes #1393.

@faho
Copy link
Member Author

@faho faho commented Feb 19, 2015

Also, does anyone mind if I remove the descriptions from unit completions?

I feel like "alsa-restore.service (Service)" isn't all too helpful. It's just repetition, after all, and removing it can simplify the code quite a bit.

@zanchey
Copy link
Member

@zanchey zanchey commented Feb 22, 2015

Are there times when the type isn't obvious e.g. mounts or sockets? Is the name always printed as alsa-restore.service? If the answers are no and yes respectively then I think that's a good change to make.

@faho
Copy link
Member Author

@faho faho commented Feb 22, 2015

I've never seen any case where systemd doesn't print the type - it's also mandatory as part of the filename, and for all arguments except for:

  • ".target" when used with systemctl isolate
  • ".service" with any other operation that takes a unit name

So yeah, it's just duplication.

faho added 4 commits Feb 22, 2015
Was single-quoted, should have been double-quoted
This includes only showing unmasked units in mask, only loaded units in
start and more types in show/list-dependencies
Unfortunately, list-unit-files doesn't understand --state=loaded

This needs a new function to explicitly use list-units

This reverts commit 9f521b7.
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Mar 7, 2015

Merged as 5a9b1b1 - sorry for the delay, and thanks!!

@zanchey zanchey added this to the next-minor milestone Mar 11, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants