Handle environment variables with = signs correctly

[crmne]

Scenario:

I need to run this line:

export THEANO_FLAGS='floatX=float32,device=gpu,nvcc.fastmath=True'

but the current implementation of the export function doesn't export anything, since the tr command would split the string at all the occurrences of the equal sign and end up having no case in the switch statement.

Solution

By using sed we ensure that the string gets split at only the first occurrence of the equal sign, emulating more carefully bash's behavior.

[faho]

This sounds okay, but I'd like a comment codifying this, so someone touching it (and I'll probably touch every single sed invocation in our codebase shortly) knows this is intentional.

[faho]

Hi, I've now pushed a slightly different solution using our new cool string tool, including a comment.

Still thanks for your contribution!

[lledey]

There is an issue with this fix, the \n is interpreted as "\n" instead of a line return.
I can't make a pull request but the fix is very simple.
Thanks.

diff --git a/share/functions/export.fish b/share/functions/export.fish
index 7c6248e..5ffd27d 100644
--- a/share/functions/export.fish
+++ b/share/functions/export.fish
@@ -5,7 +5,7 @@ function export --description 'Set global variable. Alias for set -gx, made for
         end
         for arg in $argv
                        # Only split on the first =
-            set -l v (echo $arg | string replace "=" "\n")
+            set -l v (echo $arg | string replace "=" \n)
             set -l c (count $v)
             switch $c
                     case 1

[faho]

@lledey: Well, that's embarassing. Thanks for pointing it out! Fixed in 54f2152.