Support for svn status in prompt

[samdmarshall]

This is to add support for displaying the output of svn status in a prompt similar to the way git and hg status get displayed. I tried to match the styling and conventions as best as I could, please let me know if there is any glaring issues with it.

Note: I wrote this against fish 2.2.0, so it doesn't take advantage of any of the new string manipulation features as there hasn't been published release that includes support for that yet. I would be happy to update this once a new release is made.

[faho]

The sed and grep calls could be replaced with string (not in a release yet, unfortunately).

[faho]

The sed and grep calls could be replaced with string (not in a release yet, unfortunately).

[faho]

I'll have to test this now. Any nice svn repo to try?

[faho]

I'll have to test this now. Any nice svn repo to try?

[samdmarshall]

Heh, the only public one that comes to mind is the llvm repos. This seems most work out of the svn repos I use at work.

[samdmarshall]

Heh, the only public one that comes to mind is the llvm repos. This seems most work out of the svn repos I use at work.

[samdmarshall]

OK I've updated with changes we discussed, how does it look now?

[samdmarshall]

OK I've updated with changes we discussed, how does it look now?

[faho]

As I said - this tr dance isn't necessary.

[faho]

As I said - this tr dance isn't necessary.

[samdmarshall]

Sorry about that, when i tried it out again I think i forgot to add the \n into the printf formatter not realizing that would make a significant difference in output handling. That should be fixed now.

[samdmarshall]

Sorry about that, when i tried it out again I think i forgot to add the \n into the printf formatter not realizing that would make a significant difference in output handling. That should be fixed now.

[faho]

The svn status thing is still not perfect, but given that I haven't been able to trigger it and that I don't know of any better way to do it, it's probably okay.

I'll test the new version a bit more and if it passes I'll merge.

[faho]

The svn status thing is still not perfect, but given that I haven't been able to trigger it and that I don't know of any better way to do it, it's probably okay.

I'll test the new version a bit more and if it passes I'll merge.

[samdmarshall]

OK, once a release of fish shell is made with the new string stuff I'll submit another PR converting the code over to using that where it can. That might give a bit more control around the filtering the additional lines out of svn status, I couldn't work out a simple way of doing it without introducing a lot of overhead with a set of awk commands or similar.

[samdmarshall]

OK, once a release of fish shell is made with the new string stuff I'll submit another PR converting the code over to using that where it can. That might give a bit more control around the filtering the additional lines out of svn status, I couldn't work out a simple way of doing it without introducing a lot of overhead with a set of awk commands or similar.

[faho]

That last commit changed the time from 255357 to 258585 (fish -p profile -c "__fish_svn_prompt")- in other words barely, if at all, measurable.

I've managed to get a 20% improvement, though, by removing the `math´ call.

[faho]

That last commit changed the time from 255357 to 258585 (fish -p profile -c "__fish_svn_prompt")- in other words barely, if at all, measurable.

I've managed to get a 20% improvement, though, by removing the `math´ call.

[faho]

Since you're not using $index inside the loop, you can just do seq $last_column $col. Or am I missing anything?

[samdmarshall]

it looks like it iterates an extra time when doing seq $last_column $col vs seq (math "$col - $last_column")

[faho]

I've merged this now since it's nice code that works and the time is dominated by the svn calls (I can't seem to replicate the math thing anymore). I've squashed it to f5dfebb.

Thanks for the nice work and quick response!

[faho]

I've merged this now since it's nice code that works and the time is dominated by the svn calls (I can't seem to replicate the math thing anymore). I've squashed it to f5dfebb.

Thanks for the nice work and quick response!